Implement SystemObjectTypeProvider #7008
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
No changes needing a change description found. |
live1206
changed the title
live1206
requested review from
JoshLove-msft,
jorgerangel-msft,
m-nash and
nisha-bhatia
as code owners
| : MethodSignatureModifiers.Protected | MethodSignatureModifiers.Virtual; | ||
|
|
||
| if (_shouldOverrideMethods) | ||
| if (_shouldOverrideMethods && _model.BaseModelProvider is not SystemObjectTypeProvider) |
There was a problem hiding this comment.
While we generate Azure.ResourceManager with autorest.csharp, it only implements JsonModelWriteCore.
Once we generate it with MTG, we can remove this check for SystemObjectTypeProvider
There was a problem hiding this comment.
Please file an issue and reference it in a TODO comment.
|
|
||
| if (baseSystemProperties.TryGetValue(property.Name, out var baseSystemProperty)) | ||
| { | ||
| if (DomainEqual(baseSystemProperty, property, isBaseSystemProperty: true)) |
There was a problem hiding this comment.
BaseType from Azure.ResourceManager is not handling the property generation same as MTG, i.e. adding backing field and virtual for the derived property in BaseType.
So, we need to handle it differently.
Once we generate Azure.ResourceManager with MTG, we can remove this special handling.
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Security.Cryptography.X509Certificates; |
| /// <summary> | ||
| /// Represent a type that already exists in dependencies | ||
| /// </summary> | ||
| public class SystemObjectTypeProvider : ModelProvider |
There was a problem hiding this comment.
How do we specify that this type already exists in the tsp?
| : MethodSignatureModifiers.Protected | MethodSignatureModifiers.Virtual; | ||
|
|
||
| if (_shouldOverrideMethods) | ||
| if (_shouldOverrideMethods && _model.BaseModelProvider is not SystemObjectTypeProvider) |
There was a problem hiding this comment.
Should this logic go into _shouldOverrideMethods?
| var models = new List<TypeProvider>(input.Models.Count); | ||
| foreach (var inputModel in input.Models) | ||
| { | ||
| var outputModel = CodeModelGenerator.Instance.TypeFactory.CreateModel(inputModel); |
There was a problem hiding this comment.
Could the model just be null if we shouldn't be generating it?
There was a problem hiding this comment.
We need the property and constructor signature from it while build the derived types.
If we return null here, we will need to use reflection to get the above information.
For current implementation, we don't use reflection like we did in autorest.csharp.
|
SystemObjectTypeProvider is only needed in MPG generator for now, implement it in MPG generator instead in Azure/azure-sdk-for-net#49653 |
2 participants
Resolves #5480