Add feature flag to Java generator to disable Eclipse Language Server usage#7444
Merged
alzimmermsft merged 4 commits intoMay 27, 2025
Merged
Conversation
microsoft-github-policy-service
Bot
added
the
emitter:client:java
Contributor
|
No changes needing a change description found. |
Collaborator
|
You can try these changes here
|
alzimmermsft
requested review from
XiaofeiCao,
anuchandy,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
anuchandy
approved these changes
May 27, 2025
Member
anuchandy
left a comment
anuchandy
left a comment
There was a problem hiding this comment.
Thanks Alan, looks good to me, but let's wait for Weidong and others to have a look as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding a feature flag
use-eclipse-language-serverthat will control whether the Eclipse language server is used when running cod customizations. This flag will be temporary and the default value will betrue. The long-term goal is for all projects using code customizations to set this value to false, and once that is done the flag will be removed as well as any Eclipse language server related code.The rationale behind this change is that while Eclipse language server is extremely powerful it allows for too many customizations to be used. Code customizations were originally added for niche issues found in the generators and was meant to have limited usage, which is what Eclipse language server circumvents. Additionally, it requires a large download to run and is much slower than using in-memory JavaParser capabilities.