fix: do not cache createrequest in collectionresultdef#8198
Merged
jorgerangel-msft merged 3 commits intomicrosoft:mainfrom Aug 15, 2025
Merged
fix: do not cache createrequest in collectionresultdef#8198jorgerangel-msft merged 3 commits intomicrosoft:mainfrom
jorgerangel-msft merged 3 commits intomicrosoft:mainfrom
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
jorgerangel-msft
force-pushed
the
collectionresult-caching
branch
from
336d3e8 to
ddaa466
Compare
Contributor
|
No changes needing a change description found. |
jorgerangel-msft
force-pushed
the
collectionresult-caching
branch
4 times, most recently
from
3e5f516 to
c5585af
Compare
jorgerangel-msft
requested review from
JoshLove-msft,
christothes,
jsquire and
m-nash
as code owners
jorgerangel-msft
force-pushed
the
collectionresult-caching
branch
from
c5585af to
b06ac2e
Compare
JoshLove-msft
approved these changes
Aug 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
This PR fixes an issue where both the built fields and the CreateRequest signature consumed by the CollectionResultDefinition were being cached, preventing a visitor to perform mutations on its' fields and ctors. fixes: #8202
jorgerangel-msft
removed this pull request from the merge queue due to a manual request
JoshLove-msft
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where both the built fields and the CreateRequest signature consumed by the CollectionResultDefinition were being cached, preventing a visitor to perform mutations on its' fields and ctors.
fixes: #8202