Skip to content

Upgrade VS dependnecy to fix vulnerability #8745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timotheeguerin merged 4 commits into from
Oct 16, 2025
Merged

Upgrade VS dependnecy to fix vulnerability #8745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e6c5c47
Fix build
timotheeguerin Oct 16, 2025
bf8fc10
Fix typo in VS dependency upgrade message
timotheeguerin Oct 16, 2025
2015fb3
revert
timotheeguerin Oct 16, 2025
daa0c23
revert
timotheeguerin Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-vs-vulnerability-build-2025-9-16-15-5-57.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- typespec-vs
---

Upgrade VS dependencies to fix vulnerability
10 changes: 6 additions & 4 deletions packages/typespec-vs/src/Microsoft.TypeSpec.VS.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,18 @@
<!-- The 'Microsoft.VisualStudio.Composition' is not used directly but referenced by nuget package 'Microsoft.VisualStudio.Workspace' -->
<!-- Have to add it explicitly here because otherwise 'Microsoft.VisualStudio.Workspace" will report warning NU1603 because its desired version not found and higher version will be used -->
<!-- TODO: [#5368] remove this explicit reference after 'Microsoft.VisualStudio...' releases new version without the warning-->
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.12.18" />
<PackageReference Include="Microsoft.VisualStudio.Composition" Version="17.13.41" />
<!-- Use 17.0.x or latest 16.x if no 17.0.x for compatible API-->
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.12.40392" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.VisualStudio.SDK" Version="17.14.40265" ExcludeAssets="Runtime" />
<!-- The 'Microsoft.VisualStudio.Shell.15.0' is not used directly but referenced by nuget package 'Microsoft.VisualStudio.Workspace.VSIntegration' -->
<!-- Have to add it explicitly here because otherwise 'Microsoft.VisualStudio.Workspace.VSIntegration" will report warning NU1603 because its desired version not found and higher version will be used -->
<!-- TODO: [#5368] remove this explicit reference after 'Microsoft.VisualStudio...' releases new version without the warning-->
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" Version="17.12.40392" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" Version="17.14.40264" />
<PackageReference Include="Microsoft.VisualStudio.Workspace" Version="17.12.19" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.VisualStudio.Workspace.VSIntegration" Version="17.12.19" ExcludeAssets="Runtime" />
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.9.3184">
<!-- https://github.com/advisories/GHSA-w3q9-fxm7-j8fq -->
<PackageReference Include="Microsoft.Build" Version="17.14.28"/>
<PackageReference Include="Microsoft.VSSDK.BuildTools" Version="17.14.2120">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
Loading