[Python] Fix @override to avoid duplicated subscriptionId or api-version signatures#9107
Merged
[Python] Fix @override to avoid duplicated subscriptionId or api-version signatures#9107
Conversation
msyyc
requested review from
catalinaperalta,
iscai-msft,
lmazuel,
mccoyp,
swathipil,
tadelesh and
timotheeguerin
as code owners
commit: |
Contributor
Collaborator
|
You can try these changes here
|
tadelesh
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validate Python SDK for Azure/azure-rest-api-specs#38384, I find Python SDK has duplicated subscriptionId for override Azure/azure-rest-api-specs@df79d9f. After debug, the root cause is we don't check whether subid or api-version already exists in method level signature before we handle special logic for these 2 special signatures.