Skip to content

[notcurses] new port#18752

Closed
dankamongmen wants to merge 1 commit intomicrosoft:masterfrom
dankamongmen:master
Closed

[notcurses] new port#18752
dankamongmen wants to merge 1 commit intomicrosoft:masterfrom
dankamongmen:master

Conversation

@dankamongmen
Copy link

@dankamongmen dankamongmen commented Jul 1, 2021

Add new port, Notcurses (only Linux for the short-term future)

  • What does your PR fix?

Adds a vcpkg port for Notcurses, the most powerful TUI library in the known universe.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>
    not yet!

  • Does your PR follow the [maintainer guide]

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I am still working on this PR

@PhoebeHui PhoebeHui added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 2, 2021
@JackBoosY
Copy link
Contributor

Please get failure logs here.

CMake Error at D:/downloads/tools/cmake-3.20.2-windows/cmake-3.20.2-windows-i386/share/cmake-3.20/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)

Maybe you should add the following code to portfile.cmake before vcpkg_cmake_configure:

vcpkg_find_acquire_program(PKGCONFIG)
get_filename_component(PKGCONFIG_DIR "${PKGCONFIG}" DIRECTORY )
vcpkg_add_to_path("${PKGCONFIG_DIR}") # Post install script runs pkg-config so it needs to be on PATH

@JackBoosY
Copy link
Contributor

This PR has been inactive for a long time, please reopen it if there is any progress.

@JackBoosY JackBoosY closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants