Added package for PDCurses#189
Conversation
|
Hi @jjcamp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
ports/pdcurses/portfile.cmake
Outdated
| find_program(NMAKE nmake) | ||
|
|
||
| vcpkg_download_distfile(ARCHIVE | ||
| URLS "https://sourceforge.net/projects/pdcurses/files/latest/download?source=files" |
There was a problem hiding this comment.
When pdcurs releases a new version, this link will conflict with the below hash -- could you switch this out for a stable URL?
The different download link packaged the zip slightly differently, changing the hash as well as the src path.
|
I can't believe I missed that. It is fixed now. |
|
Thanks for fixing that. After building locally, I noticed a few more issues:
|
Panel is not emitted as a dll, and is actually just a copy of the pdcurses library anyway.
|
DLLs and debug builds are now supported. However, the linter complains about the static library's ar header on my machine,
|
| @@ -0,0 +1,59 @@ | |||
| include(${CMAKE_TRIPLET_FILE}) | |||
|
|
|||
| if(VCPKG_TARGET_ARCHITECTURE STREQUAL x64) | |||
There was a problem hiding this comment.
It might be nice if we could express this in the control file.
|
Update to the linter issue, I just had some bad build artifact cached. I haven't seen the issue with several fresh builds. |
Added package for PDCurses
|
Thanks for the fixes! I added in lines to deploy the |
Add an Qt upstream patch that removes deprectated AGL linking.
Per #188, adds PDCurses package.
Since the preferred way to build PDCurses on Windows is to use the included NMake file, this implementation simply calls NMake and then copies the relevant files.