Skip to content

Added package for PDCurses#189

Merged
ras0219-msft merged 5 commits intomicrosoft:masterfrom
jjcamp:master
Oct 31, 2016
Merged

Added package for PDCurses#189
ras0219-msft merged 5 commits intomicrosoft:masterfrom
jjcamp:master

Conversation

@jjcamp
Copy link
Copy Markdown
Contributor

@jjcamp jjcamp commented Oct 20, 2016

Per #188, adds PDCurses package.

Since the preferred way to build PDCurses on Windows is to use the included NMake file, this implementation simply calls NMake and then copies the relevant files.

@msftclas
Copy link
Copy Markdown

Hi @jjcamp, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

find_program(NMAKE nmake)

vcpkg_download_distfile(ARCHIVE
URLS "https://sourceforge.net/projects/pdcurses/files/latest/download?source=files"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When pdcurs releases a new version, this link will conflict with the below hash -- could you switch this out for a stable URL?

The different download link packaged the zip slightly differently,
changing the hash as well as the src path.
@jjcamp
Copy link
Copy Markdown
Contributor Author

jjcamp commented Oct 21, 2016

I can't believe I missed that. It is fixed now.

@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for fixing that. After building locally, I noticed a few more issues:

  • We require debug builds to be built and available under debug\lib\ and debug\bin\.
  • We prefer DLLs by default if they are available. Static libs should be built when VCPKG_LIBRARY_LINKAGE is set to "static".

Panel is not emitted as a dll, and is actually just a copy of the pdcurses library anyway.
@jjcamp
Copy link
Copy Markdown
Contributor Author

jjcamp commented Oct 28, 2016

DLLs and debug builds are now supported.

However, the linter complains about the static library's ar header on my machine, which appears to be 68 bytes instead of the standard 60. I checked another machine where I had been using the static library for some time, and the header was the same (both are 64-bit Windows 10).

I'm not sure if this is a compiler bug or if vcpkg should be allowing an extra 8 bytes.

@@ -0,0 +1,59 @@
include(${CMAKE_TRIPLET_FILE})

if(VCPKG_TARGET_ARCHITECTURE STREQUAL x64)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice if we could express this in the control file.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue to track this: #229

@jjcamp
Copy link
Copy Markdown
Contributor Author

jjcamp commented Oct 28, 2016

Update to the linter issue, I just had some bad build artifact cached. I haven't seen the issue with several fresh builds.

@ras0219-msft ras0219-msft merged commit 7805bdf into microsoft:master Oct 31, 2016
ras0219-msft added a commit that referenced this pull request Oct 31, 2016
Added package for PDCurses
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for the fixes!

I added in lines to deploy the .lib files during DLL mode (they're required on Windows to link).

@ras0219-msft ras0219-msft mentioned this pull request Oct 31, 2016
JoergAtGithub added a commit to JoergAtGithub/vcpkg that referenced this pull request Dec 5, 2025
Add an Qt upstream patch that removes deprectated AGL linking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants