Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idyntree] Update to 9.0.0 #31417

Merged
merged 2 commits into from
May 22, 2023
Merged

[idyntree] Update to 9.0.0 #31417

merged 2 commits into from
May 22, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented May 12, 2023

Furthermore, remove irrlicht feature from default features as since version 9.0.0 idyntree requires irrlicht compiled with SDL support on Windows, and that is not available in irrlicht compiled by vcpkg, see https://github.com/robotology/idyntree/releases/tag/v9.0.0 .

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@traversaro traversaro changed the title [idyntree] Update idyntree port to 9.0.0 [idyntree] Update to 9.0.0 May 12, 2023
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label May 15, 2023
@MonicaLiu0311
Copy link
Contributor

MonicaLiu0311 commented May 15, 2023

When I test the feature irrlicht of x64-linux, I get the following error:

CMake Error at /home/vliumonica/i/scripts/buildsystems/vcpkg.cmake:853 (_find_package):
  By not providing "Findglfw3.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "glfw3", but
  CMake did not find one.

  Could not find a package configuration file provided by "glfw3" with any of
  the following names:

    glfw3Config.cmake
    glfw3-config.cmake

  Add the installation prefix of "glfw3" to CMAKE_PREFIX_PATH or set
  "glfw3_DIR" to a directory containing one of the above files.  If "glfw3"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  src/visualization/CMakeLists.txt:75 (find_package)


-- Configuring incomplete, errors occurred!

Should it be added as a dependency of the feature irrlicht?

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft May 15, 2023 08:19
Furthermore, remove irrlicht feature from default features as since
version 9.0.0 idyntree requires irrlicht compiled with SDL support
on Windows, and that is not available in irrlicht compiled by vcpkg.
@traversaro
Copy link
Contributor Author

When I test the feature irrlicht of x64-linux, I get the following error:

CMake Error at /home/vliumonica/i/scripts/buildsystems/vcpkg.cmake:853 (_find_package):
  By not providing "Findglfw3.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "glfw3", but
  CMake did not find one.

  Could not find a package configuration file provided by "glfw3" with any of
  the following names:

    glfw3Config.cmake
    glfw3-config.cmake

  Add the installation prefix of "glfw3" to CMAKE_PREFIX_PATH or set
  "glfw3_DIR" to a directory containing one of the above files.  If "glfw3"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  src/visualization/CMakeLists.txt:75 (find_package)


-- Configuring incomplete, errors occurred!

Should it be added as a dependency of the feature irrlicht?

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

You are right, I forgot about that. I fixed this now and I tested the irrlicht feature locally and it works fine, thanks!

@traversaro traversaro marked this pull request as ready for review May 20, 2023 10:17
@MonicaLiu0311
Copy link
Contributor

Feature assimp are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static
x64-linux

Feature irrlicht are tested successfully in the following triplet:
x64-linux

The usage test passed (header files found):

The package idyntree provides CMake targets:

    find_package(iDynTree CONFIG REQUIRED)
    target_link_libraries(main PRIVATE iDynTree::idyntree-core iDynTree::idyntree-model iDynTree::idyntree-modelio iDynTree::idyntree-modelio iDynTree::idyntree-high-level iDynTree::idyntree-estimation)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 22, 2023
@dan-shaw dan-shaw merged commit 462885c into microsoft:master May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants