Skip to content

Conversation

@dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 28, 2023

  • Don't put data into /bin.
    Simply use the same layout as for non-win32, so that portfiles don't need to care.
  • Put "libexec" tools file to /bin. Simplifies moving them to /tools/<port>.
    (Actually these are candidates for /manual-tools, but it is out of scope for this PR.)
  • Put plugins to /plugins, and QML to /qml.
  • Prevent pointless generationg of .clang-format in source directories of ports.

Revise and cleanup downstream ports which need changes. (Not changing ports which don't need changes. But revise with proper inspection of actual dependencies.)

@dg0yt dg0yt mentioned this pull request Sep 28, 2023
@Adela0814 Adela0814 added the category:port-bug The issue is with a library, which is something the port should already support label Oct 7, 2023
@MonicaLiu0311
Copy link
Contributor

Is there any new progress?

@dg0yt
Copy link
Contributor Author

dg0yt commented Mar 19, 2024

Please leave this draft open unless somebody takes over.

@PhoebeHui PhoebeHui assigned Mengna-Li and unassigned MonicaLiu0311 and Adela0814 Apr 2, 2025
@dg0yt dg0yt force-pushed the ecm branch 3 times, most recently from dbb04ee to 26a3946 Compare January 9, 2026 07:27
@dg0yt dg0yt closed this Jan 13, 2026
@dg0yt dg0yt reopened this Jan 13, 2026
@dg0yt dg0yt marked this pull request as ready for review January 13, 2026 07:12
"qt5-base",
{
"name": "qt5-base",
"default-features": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had in my PR didn't changed it to this, as e.g., this module uses the network module of Qt and therefore support of OpenSSL for https could be necessary, or?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The network module is always installed.
openssl isn't the only TLS backend.
And openssl is a default feature. Users get openssl by default. This line just enables a different choice.
So IMO default features are not necessary unless some other code says openssl is required. In that it case it should be added as an explicit feature of the dependency.

@vicroms vicroms closed this Jan 16, 2026
@vicroms vicroms reopened this Jan 16, 2026
@SunBlack
Copy link
Contributor

SunBlack commented Jan 22, 2026

@dg0yt Once you have the CI up and running, could you see if you can include the upgrade to 6.22 (so there is no need to maybe update the patches again a few days after this PR is getting merged)? I saw in #49541 that @Neumann-A patches kf6archive there. However, this patch is unnecessary if we update the port to at least 6.20 (see commit) - but then we need at least the same ECM version.

@dg0yt
Copy link
Contributor Author

dg0yt commented Jan 22, 2026

I don't want to add more changes.

Note the existing kf6archive/kf5archive pattern is different from what happened with kf5diagram in #49313.

@dg0yt dg0yt closed this Jan 22, 2026
@dg0yt dg0yt reopened this Jan 22, 2026
@dg0yt dg0yt closed this Jan 23, 2026
@dg0yt dg0yt reopened this Jan 23, 2026
@SunBlack
Copy link
Contributor

Seems the CI is already in the weekend 😅

##[error]We stopped hearing from agent CPPMAC-ARM64-09. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

@dg0yt dg0yt closed this Jan 24, 2026
@dg0yt dg0yt reopened this Jan 24, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever!

@vicroms vicroms merged commit f14401c into microsoft:master Jan 25, 2026
17 checks passed
@dg0yt dg0yt deleted the ecm branch January 25, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants