-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[ecm] Force vcpkg filesystem, revise downstream #34091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is there any new progress? |
|
Please leave this draft open unless somebody takes over. |
dbb04ee to
26a3946
Compare
Uniform behaviour across platforms. Facilitate vcpkg_copy_tools(... AUTO_CLEAN).
| "qt5-base", | ||
| { | ||
| "name": "qt5-base", | ||
| "default-features": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had in my PR didn't changed it to this, as e.g., this module uses the network module of Qt and therefore support of OpenSSL for https could be necessary, or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network module is always installed.
openssl isn't the only TLS backend.
And openssl is a default feature. Users get openssl by default. This line just enables a different choice.
So IMO default features are not necessary unless some other code says openssl is required. In that it case it should be added as an explicit feature of the dependency.
|
@dg0yt Once you have the CI up and running, could you see if you can include the upgrade to 6.22 (so there is no need to maybe update the patches again a few days after this PR is getting merged)? I saw in #49541 that @Neumann-A patches kf6archive there. However, this patch is unnecessary if we update the port to at least 6.20 (see commit) - but then we need at least the same ECM version. |
|
I don't want to add more changes. Note the existing kf6archive/kf5archive pattern is different from what happened with kf5diagram in #49313. |
|
Seems the CI is already in the weekend 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever!
/bin.Simply use the same layout as for non-win32, so that portfiles don't need to care.
/bin. Simplifies moving them to/tools/<port>.(Actually these are candidates for
/manual-tools, but it is out of scope for this PR.)/plugins, and QML to/qml..clang-formatin source directories of ports.Revise and cleanup downstream ports which need changes. (Not changing ports which don't need changes. But revise with proper inspection of actual dependencies.)