Skip to content

[vcpkg scripts] Update msys2#39088

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:vcpkg-ci-msys2
Jun 10, 2024
Merged

[vcpkg scripts] Update msys2#39088
BillyONeal merged 2 commits intomicrosoft:masterfrom
dg0yt:vcpkg-ci-msys2

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Jun 2, 2024

msys2-runtime no longer supports Windows 7 since version 3.5. msys2-runtime-3.4 is the replacement for user who cannot upgrade. YMMV.

autoconf-wrapper is not updated, cf. #36774.

pkgconf is not updated, waiting for 2.2.

@dg0yt
[vcpkg scripts] Update msys, pin 3.4 runtime
63d831c 
Msys2/Cygwin runtime 3.5 no longer supports Windows 7.
@Osyotr
Copy link
Copy Markdown
Contributor

Osyotr commented Jun 2, 2024

Are Windows 7 dev machines still a thing?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 2, 2024

Are Windows 7 dev machines still a thing?

I don't know but some industries might be very conservative. IIUC vcpkg tool is kept running on Windows 7, and it is still the minimum requirement at https://github.com/Microsoft/vcpkg?tab=readme-ov-file#quick-start-windows.

@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jun 3, 2024
@dg0yt dg0yt marked this pull request as ready for review June 3, 2024 04:55
Cheney-W
Cheney-W previously approved these changes Jun 4, 2024
View reviewed changes
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jun 4, 2024
@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 6, 2024
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jun 7, 2024

We discussed this PR during our weekly meeting:

We are due to update our documented minimum requirements. The new minimum supported versions for Windows are 8.1 onwards.

@vicroms vicroms removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jun 7, 2024
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 7, 2024

Fine, I will update the PR soon.

@dg0yt dg0yt marked this pull request as draft June 7, 2024 11:00
@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Jun 7, 2024

Is there an automatic script for updating the msys stuff?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 7, 2024

Is there an automatic script for updating the msys stuff?

There is (limited) automation via vcpkg-ci-msys2[update-all].
It still needs human brain to review what to merge and which dependencies to override.

And I run it on linux with --allow-unsupported.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 7, 2024

Maybe related: #39171 (comment)

@dg0yt dg0yt changed the title [vcpkg scripts] Update msys, pin 3.4 runtime [vcpkg scripts] Update msys2 Jun 7, 2024
@dg0yt dg0yt marked this pull request as ready for review June 7, 2024 13:50
m-kuhn added a commit to kadas-albireo/kadas-albireo2 that referenced this pull request Jun 7, 2024
@m-kuhn
Test microsoft/vcpkg#39088
93ea915
m-kuhn added a commit to kadas-albireo/kadas-albireo2 that referenced this pull request Jun 7, 2024
@m-kuhn
Test microsoft/vcpkg#39088
12ab029
@dg0yt dg0yt closed this Jun 10, 2024
@dg0yt dg0yt reopened this Jun 10, 2024
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Jun 10, 2024

We are due to update our documented minimum requirements. The new minimum supported versions for Windows are 8.1 onwards.

This is applied in MicrosoftDocs/vcpkg-docs#339

@dg0yt Thank you for the update.

@BillyONeal BillyONeal merged commit 856cd49 into microsoft:master Jun 10, 2024
@dg0yt dg0yt deleted the vcpkg-ci-msys2 branch June 11, 2024 03:06
daschuer pushed a commit to daschuer/vcpkg that referenced this pull request Jan 15, 2025
@dg0yt @daschuer
[vcpkg scripts] Update msys2 (microsoft#39088)
924e165 
msys2-runtime no longer supports Windows 7 since version 3.5.
msys2-runtime-3.4 is the replacement for user who cannot upgrade. YMMV.

autoconf-wrapper is not updated, cf. microsoft#36774.

pkgconf is not updated, waiting for 2.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cheney-W Cheney-W Cheney-W left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

Labels

category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dg0yt @Osyotr @vicroms @Neumann-A @BillyONeal @Cheney-W