[curve-coco] add new port #49137
Merged
[curve-coco] add new port #49137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg0yt
reviewed
Dec 28, 2025
Contributor
dg0yt
left a comment
dg0yt
left a comment
There was a problem hiding this comment.
Just another cursory review on GH.
ports/curve-coco/portfile.cmake
Outdated
| @@ -0,0 +1,30 @@ | |||
| # Header-only library | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Header-only library | |
| set(VCPKG_BUILD_TYPE release) # header-only library | |
ports/curve-coco/portfile.cmake
Outdated
| vcpkg_cmake_configure(SOURCE_PATH "${SOURCE_PATH}") | ||
|
|
||
| vcpkg_cmake_install() | ||
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/coco-${VERSION}) |
Contributor
There was a problem hiding this comment.
Suggested change
| vcpkg_cmake_config_fixup(CONFIG_PATH lib/cmake/coco-${VERSION}) | |
| vcpkg_cmake_config_fixup(CONFIG_PATH "lib/cmake/coco-${VERSION}" PACKAGE_NAME "coco") |
(Guessing package name from config path.)
ports/curve-coco/portfile.cmake
Outdated
Comment on lines
27
to
28
| # remove empty lib and debug/lib directories (and duplicate files from debug/include) | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug" "${CURRENT_PACKAGES_DIR}/lib") |
Contributor
There was a problem hiding this comment.
Suggested change
| # remove empty lib and debug/lib directories (and duplicate files from debug/include) | |
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug" "${CURRENT_PACKAGES_DIR}/lib") | |
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/lib") # from CMake config |
| # +-------------------------------------------------------------------------------------------------------+ | ||
|
|
||
| add_library(${PROJECT_NAME} STATIC "src/latch.cpp" "src/stray.cpp") | ||
| -add_library(cr::${PROJECT_NAME} ALIAS ${PROJECT_NAME}) |
Contributor
There was a problem hiding this comment.
Does this need to be removed?
Contributor
Author
There was a problem hiding this comment.
The alias seems to be defined in PackageProject.cmake.
https://github.com/Curve/coco/blob/master/CMakeLists.txt#L61-L68
https://github.com/TheLartians/PackageProject.cmake/blob/master/CMakeLists.txt#L40-L41
vicroms
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.https://github.com/Curve/coco/
ereignis requires coco since 5.0.0.