Skip to content

[vcpkg_from_git] Unshallow when fetching FETCH_REF#49293

Merged
vicroms merged 3 commits intomicrosoft:masterfrom
touraill-adobe:fix-49281
Jan 29, 2026
Merged

[vcpkg_from_git] Unshallow when fetching FETCH_REF#49293
vicroms merged 3 commits intomicrosoft:masterfrom
touraill-adobe:fix-49281

Conversation

@touraill-adobe
Copy link
Copy Markdown
Contributor

Fixes #49281.

vicroms
vicroms previously approved these changes Jan 8, 2026
@vicroms vicroms force-pushed the fix-49281 branch 2 times, most recently from 83ba955 to 8d6dee1 Compare January 9, 2026 00:06
@touraill-adobe
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree company="Adobe"

@touraill-adobe
Copy link
Copy Markdown
Contributor Author

@vicroms Thanks for grooming this PR! I'm confused by the CI failures, are they happening because my change impacts most cmake ports so they are all rebuilt, but some of them are in fact already broken regardless of my modification? If so, should those issues be fixed in a separate PR and mine rebased on top of it?

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jan 9, 2026

aeron and dpdk had recent updates that built successfully in their own PRs but have issues in the full "all packages" CI, this can sometimes affect PRs such as this one.

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jan 14, 2026

Depends on #49284

@vicroms vicroms marked this pull request as draft January 14, 2026 09:11
@vicroms vicroms added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 14, 2026
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Jan 19, 2026

Depends on #49284

That PR is merged now. This PR needs to be marked ready-for-review.

@vicroms vicroms marked this pull request as ready for review January 19, 2026 08:20
@vicroms vicroms closed this Jan 19, 2026
@vicroms vicroms reopened this Jan 19, 2026
@vicroms
Copy link
Copy Markdown
Member

vicroms commented Jan 22, 2026

More baseline issues, I'll make a new PR to fix them

Now waiting for #49559

@vicroms vicroms marked this pull request as draft January 25, 2026 08:28
@vicroms vicroms closed this Jan 27, 2026
@vicroms vicroms reopened this Jan 27, 2026
@vicroms vicroms marked this pull request as ready for review January 27, 2026 06:10
Copy link
Copy Markdown
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in upstream

Comment thread scripts/ci.baseline.txt Outdated
Comment thread scripts/ci.feature.baseline.txt Outdated
@vicroms vicroms enabled auto-merge (squash) January 28, 2026 09:16
@vicroms vicroms merged commit b0a66e6 into microsoft:master Jan 29, 2026
17 checks passed
@dg0yt dg0yt mentioned this pull request Feb 3, 2026
7 tasks
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Feb 3, 2026

Note #49788 (comment):

fatal: --unshallow on a complete repository does not make sense

@BillyONeal
Copy link
Copy Markdown
Member

Should we revert this then?

@touraill-adobe
Copy link
Copy Markdown
Contributor Author

Arf sorry about that, it didn't occur to me that git could disallow that and I didn't stumble upon the issue when testing 😞. I suppose a solution could be to check if the repository is shallow beforehand (e.g. with git rev-parse --is-shallow-repository).

@BillyONeal
Copy link
Copy Markdown
Member

To bring this back I think it should have that and also be some form of opt-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vcpkg_from_git] REF not found when using FETCH_REF because of shallow fetch

4 participants