Skip to content

Revert "[slang] Add new port (version 10.0)"#50176

Merged
JavierMatosD merged 1 commit intomasterfrom
revert-50116-tkp/slang
Feb 25, 2026
Merged

Revert "[slang] Add new port (version 10.0)"#50176
JavierMatosD merged 1 commit intomasterfrom
revert-50116-tkp/slang

Conversation

@JavierMatosD
Copy link
Copy Markdown
Contributor

Reverts #50116

@timkpaine unfortunately, I have to revert this PR due to file conflicts with the port shader-slang which places configs in share\slang with the same config names. I'll open another PR that adds the port again, but the configs will need to be renamed.

@BillyONeal
Copy link
Copy Markdown
Member

image

In a situation where we can only pick one they search rank about the same :(

@timkpaine
Copy link
Copy Markdown
Contributor

timkpaine commented Feb 25, 2026

Should shader-slang configs be similarly renamed? Seems sensible to keep them each to their own names

@JavierMatosD
Copy link
Copy Markdown
Contributor Author

Repology says upstream is slang-verilog https://aur.archlinux.org/packages/slang-verilog

@timkpaine
Copy link
Copy Markdown
Contributor

So sounds like it makes sense, for the avoidance of confusion, to rename both sets

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Feb 25, 2026

FTR the conflict is about the slang CMake package name. The names are chosen by upstreams, not by vcpkg.

It is easy to have separate dirs for different providers of the same name.
But it takes extra hints to choose the desired provider if both are installed.

`

@JavierMatosD JavierMatosD merged commit 523e6cb into master Feb 25, 2026
15 checks passed
@BillyONeal
Copy link
Copy Markdown
Member

But it takes extra hints to choose the desired provider if both are installed.

Is there an obvious way to do that we could put in usage text?

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Feb 26, 2026

But it takes extra hints to choose the desired provider if both are installed.

Is there an obvious way to do that we could put in usage text?

I'm afraid it is a minefield. (And then there is transitive usage.)

@timkpaine
Copy link
Copy Markdown
Contributor

What's next? Should I reopen my original PR and someone can apply the necessary changes?

@timkpaine
Copy link
Copy Markdown
Contributor

What's next? Should I reopen my original PR and someone can apply the necessary changes?

bump

@BillyONeal BillyONeal deleted the revert-50116-tkp/slang branch March 30, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants