Merged
Conversation
dg0yt
commented
Feb 26, 2026
| else() | ||
| set(_lib3mf_external_link_visibility PRIVATE) | ||
| if (NOT LIB3MF_BUILD_SHARED) | ||
| - set(_lib3mf_external_link_visibility PUBLIC) |
Contributor
Author
There was a problem hiding this comment.
If it is private with shared libs, then it is private also with static libs.
(I found no reference to libzip and zlib headers in installed headers.)
dg0yt
commented
Feb 26, 2026
|
|
||
| Requires: | ||
| -Libs: -L${libdir} -l3mf -lzip -lz | ||
| +Requires.private: libzip zlib |
Contributor
Author
There was a problem hiding this comment.
There is no library z on vcpkg MSVC platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.