Skip to content

[gtk3] fix when building with wayland support#51391

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
AenBleidd:vko_fix_gtk3_build_with_wayland
Apr 27, 2026
Merged

[gtk3] fix when building with wayland support#51391
BillyONeal merged 1 commit intomicrosoft:masterfrom
AenBleidd:vko_fix_gtk3_build_with_wayland

Conversation

@AenBleidd
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Copilot AI review requested due to automatic review settings April 26, 2026 04:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps the gtk3 port revision and adjusts the Wayland feature configuration to address build issues when enabling Wayland support.

Changes:

  • Increment gtk3 port-version from 1 → 2 and update versioning metadata (baseline + versions DB entry).
  • Add libxkbcommon as a dependency of the wayland feature.
  • Extend Meson configuration to optionally provide an explicit wayland-scanner path via ADDITIONAL_BINARIES.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
versions/g-/gtk3.json Adds a new 3.24.52 entry with port-version: 2 and updated git-tree.
versions/baseline.json Updates the repo baseline for gtk3 to port-version: 2.
ports/gtk3/vcpkg.json Bumps port-version and adds libxkbcommon to the wayland feature dependencies.
ports/gtk3/portfile.cmake Adds conditional Meson ADDITIONAL_BINARIES injection for wayland-scanner.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ports/gtk3/portfile.cmake Outdated
Comment thread ports/gtk3/portfile.cmake Outdated
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd AenBleidd force-pushed the vko_fix_gtk3_build_with_wayland branch from 292f8be to 413b17e Compare April 27, 2026 07:04
Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal BillyONeal enabled auto-merge (squash) April 27, 2026 07:22
@BillyONeal BillyONeal merged commit 73248d8 into microsoft:master Apr 27, 2026
16 checks passed
@AenBleidd AenBleidd deleted the vko_fix_gtk3_build_with_wayland branch April 27, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants