Rename curve ports to include a namespace within their port names#51394
Rename curve ports to include a namespace within their port names#51394BillyONeal merged 3 commits intomicrosoft:masterfrom
Conversation
34c1384 to
1d6eda0
Compare
|
@Curve @MehdiChinoune @yurybura @mutptr Tagging you because you have edited one of these in the past. Given that several of these have likely to conflict names and the set is only growing over time I think @SunBlack makes a good point but I would like to give folks who might care a chance to chime in. There's also no requirement that we necessarily have to rename any of the existing ones; the names are already effectively "given away" so we could say to only do this for anything added. But @Curve et al. may appreciate all their libraries sorting together. |
|
No, I didn't touch any of them in the past. |
I tagged you due to #30368 |
|
I see now: saucer is implicated but is just a customer itself. Sorry for the extra ping :) |
I think this makes sense - my libraries often have single word names that could conflict with others. Out of curiosity: Is this the first instance of using namespaces for the ports? If so, I think this is actually a good idea in general :) |
It's a very good idea to make names more unique and avoid name conflicts. |
| { | ||
| "name": "eraser", | ||
| "version": "2.3.0", | ||
| "version-string": "deprecated", |
There was a problem hiding this comment.
Please just deindex these rather than leaving empty ports.
There was a problem hiding this comment.
So there's no more transition period where the old port redirects to the new one (and yes, I forgot to set up the redirect)?
There was a problem hiding this comment.
I think what we have found over time is that those redirects end up counterproductive. Now that we made sure it doesn't break folks using manifest mode we have been much more willing to just deindex stuff.
There was a problem hiding this comment.
Good to know that the behavior with old ports has now changed 👍
@Curve There is a "Use distinctive port names" guideline: |
|
Anyone seeing the reason, why the CI want to readd the removed ports (see summary). |
I did touch that recently... maybe there's another bug. Let's see if merging fixes it |
|
:sigh: This is what I get for touching ANYTHING |
ba65774 to
7092ff7
Compare
|
OK, this should be fixed in #51431. If build results come back OK except for that check I will merge through it. (Sorry for touching this PR; I did not mean to) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |

./vcpkg x-add-version --alland committing the result.Solves #49096