Skip to content

Rename curve ports to include a namespace within their port names#51394

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
SunBlack:curve
Apr 29, 2026
Merged

Rename curve ports to include a namespace within their port names#51394
BillyONeal merged 3 commits intomicrosoft:masterfrom
SunBlack:curve

Conversation

@SunBlack
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Solves #49096

@SunBlack SunBlack force-pushed the curve branch 2 times, most recently from 34c1384 to 1d6eda0 Compare April 26, 2026 17:25
@BillyONeal
Copy link
Copy Markdown
Member

@Curve @MehdiChinoune @yurybura @mutptr Tagging you because you have edited one of these in the past. Given that several of these have likely to conflict names and the set is only growing over time I think @SunBlack makes a good point but I would like to give folks who might care a chance to chime in.

There's also no requirement that we necessarily have to rename any of the existing ones; the names are already effectively "given away" so we could say to only do this for anything added. But @Curve et al. may appreciate all their libraries sorting together.

@BillyONeal BillyONeal added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 27, 2026
@MehdiChinoune
Copy link
Copy Markdown
Contributor

No, I didn't touch any of them in the past.

@BillyONeal
Copy link
Copy Markdown
Member

No, I didn't touch any of them in the past.

I tagged you due to #30368

@BillyONeal
Copy link
Copy Markdown
Member

I see now: saucer is implicated but is just a customer itself. Sorry for the extra ping :)

@Curve
Copy link
Copy Markdown
Contributor

Curve commented Apr 27, 2026

@Curve @MehdiChinoune @yurybura @mutptr Tagging you because you have edited one of these in the past. Given that several of these have likely to conflict names and the set is only growing over time I think @SunBlack makes a good point but I would like to give folks who might care a chance to chime in.

There's also no requirement that we necessarily have to rename any of the existing ones; the names are already effectively "given away" so we could say to only do this for anything added. But @Curve et al. may appreciate all their libraries sorting together.

I think this makes sense - my libraries often have single word names that could conflict with others.

Out of curiosity: Is this the first instance of using namespaces for the ports? If so, I think this is actually a good idea in general :)

@yurybura
Copy link
Copy Markdown
Contributor

I think @SunBlack makes a good point but I would like to give folks who might care a chance to chime in.

It's a very good idea to make names more unique and avoid name conflicts.

@BillyONeal BillyONeal removed the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 27, 2026
Comment thread ports/eraser/vcpkg.json Outdated
{
"name": "eraser",
"version": "2.3.0",
"version-string": "deprecated",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just deindex these rather than leaving empty ports.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there's no more transition period where the old port redirects to the new one (and yes, I forgot to set up the redirect)?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what we have found over time is that those redirects end up counterproductive. Now that we made sure it doesn't break folks using manifest mode we have been much more willing to just deindex stuff.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know that the behavior with old ports has now changed 👍

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 28, 2026

Out of curiosity: Is this the first instance of using namespaces for the ports? If so, I think this is actually a good idea in general :)

@Curve There is a "Use distinctive port names" guideline:
https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#check-names-against-other-repositories

@SunBlack
Copy link
Copy Markdown
Contributor Author

SunBlack commented Apr 28, 2026

Anyone seeing the reason, why the CI want to readd the removed ports (see summary).

@BillyONeal
Copy link
Copy Markdown
Member

Anyone seeing the reason, why the CI want to readd the removed ports (see summary).

I did touch that recently... maybe there's another bug. Let's see if merging fixes it

@BillyONeal
Copy link
Copy Markdown
Member

:sigh: This is what I get for touching ANYTHING

@BillyONeal
Copy link
Copy Markdown
Member

image

Sorry, juggling too many balls at once and accidentally pushed to the wrong thing

@BillyONeal
Copy link
Copy Markdown
Member

OK, this should be fixed in #51431. If build results come back OK except for that check I will merge through it. (Sorry for touching this PR; I did not mean to)

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BillyONeal BillyONeal enabled auto-merge (squash) April 29, 2026 00:29
@BillyONeal
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal merged commit 9e9d930 into microsoft:master Apr 29, 2026
16 checks passed
@SunBlack SunBlack deleted the curve branch April 29, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants