Skip to content

[lerc] Update to 4.1#51530

Merged
BillyONeal merged 7 commits into
microsoft:masterfrom
dg0yt:lerc
May 6, 2026
Merged

[lerc] Update to 4.1#51530
BillyONeal merged 7 commits into
microsoft:masterfrom
dg0yt:lerc

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented May 3, 2026

As reviewed. Closes #50592.

4.1.1 is a "js" (i.e. Javascript) tag and not a (C++) release.
Every other repo has 4.1.0:
https://repology.org/project/lerc/versions
But 4.1.1 has C++ changes w.r.t 4.1.0:
Esri/lerc@v4.1.0...js_v4.1.1

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented May 3, 2026

Depends on #51516.

@BillyONeal
Copy link
Copy Markdown
Member

mathgl:

ninja: error: '/usr/lib/x86_64-linux-gnu/libXft.so', needed by 'utils/mglview', missing and no known rule to make it

octave:

/usr/bin/ld: cannot find -lXft: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:13119: libinterp/dldfcn/__fltk_uigetfile__.la] Error 1
make[2]: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lXft: No such file or directory
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:13131: libinterp/dldfcn/__init_fltk__.la] Error 1
make[1]: *** [Makefile:28742: all-recursive] Error 1
make: *** [Makefile:11735: all] Error 2

These seem legitimate.

@BillyONeal BillyONeal marked this pull request as draft May 5, 2026 01:37
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented May 5, 2026

These seem legitimate.

No. This has been popping up in some CI runs before.

@dg0yt dg0yt marked this pull request as ready for review May 5, 2026 04:01
@BillyONeal
Copy link
Copy Markdown
Member

So why just "no" out of hand? It's true that our CI system is not 100% bulletproof but I've not seen X libraries just randomly get injected or not exist. (If it passes on rerun, great.)

@BillyONeal
Copy link
Copy Markdown
Member

Identical errors on rerun.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented May 6, 2026

Yeah, and still it is not related to the lerc changes. Things were fine on May 3, apart from the other baseline regression.
(It may be related to installation order lottery vs binary caching after invalidating most of the cache. And that's how it magically disappears when you think you get closer.)

And of course not yet reproducible locally.

But hey, I get the same error in the tcl PR: https://dev.azure.com/vcpkg/public/_build/results?buildId=131240&view=results

@BillyONeal
Copy link
Copy Markdown
Member

But hey, I get the same error in the tcl PR: https://dev.azure.com/vcpkg/public/_build/results?buildId=131240&view=results

Huh, interesting, OK I'm sold that it's some kind of baseline issue. Let me see if I can pull the fltk binary cache entry...

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented May 6, 2026

OK, both broken runs had ABI SHA 4cba3965e0f7fcf2771ed15737dad6542d9b28abded996e677bb9825d8994b13 . I am firewalled from that storage account from home (where I am now), I'll pull that and see if there's anything obviously funny when I get to the office in the morning tomorrow.

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for baseline pain!

@BillyONeal
Copy link
Copy Markdown
Member

image

.pc file didn't meaningfully change

image

Binary does not contain "-lXft"

I'm going to merge through this. Stand by...

@BillyONeal BillyONeal merged commit 7fb558b into microsoft:master May 6, 2026
14 of 16 checks passed
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented May 6, 2026

#51569 is playing with fltk.

@dg0yt dg0yt deleted the lerc branch May 6, 2026 03:25
@BillyONeal BillyONeal mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants