Make sure Serf can build on Visual Studio 2026.#51629
Closed
d-sahlberg wants to merge 1 commit into
Closed
Conversation
…ommit r1933327. Add a new patch and update portfile to apply the patch.
Author
|
@microsoft-github-policy-service agree |
Author
|
After some comments, I will redact this PR and come back with an updated version. |
Contributor
|
I suggest the following changes to potentially fix the warnings: From a3ba51b0ff219557441b8499d5b1d6bd70032d0e Mon Sep 17 00:00:00 2001
From: Timofei Zhakov <tima@chemodax.net>
Date: Sun, 10 May 2026 20:32:08 +0200
Subject: [PATCH 1/2] [serf] bump port version
---
ports/serf/vcpkg.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ports/serf/vcpkg.json b/ports/serf/vcpkg.json
index c5be429a94..e3ce9ec313 100644
--- a/ports/serf/vcpkg.json
+++ b/ports/serf/vcpkg.json
@@ -1,7 +1,7 @@
{
"name": "serf",
"version": "1.3.10",
- "port-version": 1,
+ "port-version": 2,
"description": "The serf library is a high performance C-based HTTP client library built upon the Apache Portable Runtime (APR) library. It is permissively licensed under the Apache License, v2.",
"homepage": "https://serf.apache.org/",
"license": "Apache-2.0",
--
2.54.0From 05e96b81ec8b8001e0b17df802031841689e7024 Mon Sep 17 00:00:00 2001
From: Timofei Zhakov <tima@chemodax.net>
Date: Sun, 10 May 2026 20:32:51 +0200
Subject: [PATCH 2/2] [serf] regenerate version manifest
---
versions/baseline.json | 2 +-
versions/s-/serf.json | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/versions/baseline.json b/versions/baseline.json
index 515c26b24d..2c553971f0 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -9162,7 +9162,7 @@
},
"serf": {
"baseline": "1.3.10",
- "port-version": 1
+ "port-version": 2
},
"sese": {
"baseline": "2.3.0",
diff --git a/versions/s-/serf.json b/versions/s-/serf.json
index b6ab6aa7f0..81b0263eed 100644
--- a/versions/s-/serf.json
+++ b/versions/s-/serf.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "85331a2b644438890a4c6a3398c42cf273a2f060",
+ "version": "1.3.10",
+ "port-version": 2
+ },
{
"git-tree": "b6de178033cf4863ae254effe4d99276f66eb14e",
"version": "1.3.10",
--
2.54.0Which updates port-version in port.vcpkg and runs I didn't push it to run the tests though... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Serf trunk commit r1933327.
Add a new patch and update portfile to apply the patch.
./vcpkg x-add-version --alland committing the result.