[scripts] Add support for Python 3.13 and 3.14 tools#51807
Conversation
Signed-off-by: Michael Oliver <mcoliver@gmail.com>
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
This seems to confuse the different pythons, not that I can blame anyone for being confused by the situation.
vcpkg_find_acquire_program(PYTHON3) is for "I have a random .py script I want to execute during my build, /usr/bin/python3 or whatever version happens to be on the system already is acceptable", the port python is for the "I need a particular version and/or to build modules that can be loaded by python"
That Python is both a common embedded component and a "general system utility" deployed on many POSIX systems unfortunately puts us in a place where we can't really have a single answer to "what is Python?"
| @@ -0,0 +1,38 @@ | |||
| if(CMAKE_HOST_WIN32) | |||
There was a problem hiding this comment.
I think at this point we are going to decline to add further vcpkg_find_acquire_program entries given that that they can't be versioned. If someone needs that specific of a version, they need to depend on the port instead.
| @@ -1,5 +1,15 @@ | |||
| { | |||
| "versions": [ | |||
| { | |||
There was a problem hiding this comment.
This is damaged: the python3 port isn't being edited so the version database should not be being edited.
| set(download_sha512 71c1ce33aa484935306b1a24c75b26193463bb475aa6e1c0f94767649caa22a862c49b2eb341d21f3d8428ae0e4243d5cae1488a83f9f598e23678ee8c548ad8) | ||
| endif() | ||
|
|
||
| # Remove this after the next update |
There was a problem hiding this comment.
Seems like this should be removed.
| @@ -1,29 +1,29 @@ | |||
| if(CMAKE_HOST_WIN32) | |||
| set(program_name python) | |||
There was a problem hiding this comment.
I think this whole thing should likely be replaced with z_use_vcpkg_fetch(PYTHON3) and adding the missing non-Windows entries to
vcpkg/scripts/vcpkg-tools.json
Line 5 in 371d1f7
2 participants
Fixes #46556 #47791
./vcpkg x-add-version --alland committing the result.