Retarget to netcoreapp3.1 and test on net5.0 #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
force-pushed
the
netcoreapp3.1
branch
from
f6b930e to
a9666fe
Compare
sharwell
reviewed
Feb 6, 2021
| staFailure = ex; | ||
| } | ||
| }); | ||
| #pragma warning disable CA1416 // Validate platform compatibility |
Contributor
There was a problem hiding this comment.
💭 you would have the option of targeting net5.0-windows instead of just net5.0
Member
Author
There was a problem hiding this comment.
But I want most of these tests to run on other OS's, and all these tests already check the OS first, but the analyzer can't see that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.