Add managed identity support for connecting to container registries#745
Merged
MicroFish91 merged 23 commits intomainfrom Oct 4, 2024
Merged
Add managed identity support for connecting to container registries#745MicroFish91 merged 23 commits intomainfrom
MicroFish91 merged 23 commits intomainfrom
Conversation
MicroFish91
force-pushed
the
mwf/cr-iii
branch
from
83a6594 to
2c926dd
Compare
nturinski
approved these changes
Oct 3, 2024
Member
nturinski
left a comment
nturinski
left a comment
There was a problem hiding this comment.
Overall, everything looks good to me. Just small comments/nits, but I don't want to block progress based on that.
| // data: RegistryCredentialType.SystemAssigned, | ||
| // }); | ||
| picks.push({ | ||
| label: 'Managed Identity', |
Member
There was a problem hiding this comment.
nit: Should localize both strings.
Contributor
Author
There was a problem hiding this comment.
I'll localize the recommended, but do we want to localize Managed Identity? I was treating it like the official resource title and so wasn't thinking to add localization
Member
There was a problem hiding this comment.
I assume that Chinese or Korean would localize it to say Managed Identity, but in that language.
src/commands/registryCredentials/identity/ManagedEnvironmentIdentityEnableStep.ts
Outdated
Show resolved
Hide resolved
src/commands/registryCredentials/identity/ManagedEnvironmentIdentityEnableStep.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Part 1 of #719
Example
A few additional notes:
deployWorkspaceProjectApi... I will add that change in a follow-up PR. Those API changes will impact the Containerized Functions featureImplementation:
system-environmentregistry credential on the container app envelope. This will tell the service to use the permission level assigned to the managed environment. This permission level gets passed down to the child container app.