azure: Add async validation for storage account name step#2249
Merged
azure: Add async validation for storage account name step#2249
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the UX responsiveness of the storage account name prompt by splitting validation into immediate synchronous checks and a deferred async availability check, using asyncValidationTask to avoid blocking the typing/validation loop with a network call.
Changes:
- Split storage account name validation into
validateStorageAccountNameSync(local rules) andvalidateStorageAccountNameAvailability(ARMcheckNameAvailability). - Wire
validateInputto the sync validator andasyncValidationTaskto the availability check in the input box prompt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bwateratmsft
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the big C, this was the issue:
So moving to the asyncValidate call should fix this.
Summary
Splits the storage account name validation in
StorageAccountNameStepinto synchronous and asynchronous parts:validateStorageAccountNameSync— Performs instant client-side checks (length constraints, invalid characters) so the user gets immediate feedback while typing.validateStorageAccountNameAvailability— CallscheckNameAvailabilityon the storage management client asynchronously via the newasyncValidationTaskinput box option, so the availability check no longer blocks the synchronous validation path.This improves the responsiveness of the storage account name input box by deferring the network call to the async validation task.