Skip to content

Use .NET's newer -getProperty capability#335

Merged
bwateratmsft merged 10 commits intomainfrom
bmw/netGetProperty
Jan 14, 2026
Merged

Use .NET's newer -getProperty capability#335
bwateratmsft merged 10 commits intomainfrom
bmw/netGetProperty

Conversation

@bwateratmsft
Copy link
Copy Markdown
Collaborator

@bwateratmsft bwateratmsft commented Jan 12, 2026

Fixes #195. This replaces our confusing targets files with simpler command lines and parsing. I also added some refinements to ensure that the expected data is always present, or else a good error message is thrown.

Makes a few important changes as well based on current supported .NET versions--

  • For .NET project info:
    • No longer includes the workarounds for .NET 10 Previews 3-6
    • No longer considers the SDKContainerSupportEnabled property
  • For Blazor info:
    • No longer supports XML manifests (they are out-of-support in .NET)

Things to test:

  • .NET 10
    • SDK
    • Dockerfile
  • .NET 9
    • SDK
    • Dockerfile
  • .NET 8
    • SDK
    • Dockerfile
  • Blazor w/ static web assets (any supported version is sufficient proof)

@bwateratmsft bwateratmsft requested a review from a team as a code owner January 12, 2026 15:52

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/utils/netCoreUtils.ts
Comment thread src/utils/netCoreUtils.ts Outdated
Comment thread src/utils/netCoreUtils.ts
@bwateratmsft bwateratmsft enabled auto-merge (squash) January 14, 2026 18:25
Comment thread src/debugging/netSdk/NetSdkDebugHelper.ts
Comment thread src/utils/netCoreUtils.ts Outdated
Comment thread src/utils/netCoreUtils.ts Outdated
Comment thread src/debugging/netcore/NetCoreDebugHelper.ts
patverb
patverb previously approved these changes Jan 14, 2026
@bwateratmsft bwateratmsft merged commit 8c72a0c into main Jan 14, 2026
2 checks passed
@bwateratmsft bwateratmsft deleted the bmw/netGetProperty branch January 14, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Utilize dotnet's newer -getProperty:foo for doing all our MSBuild property lookups

3 participants