nes: debt: remove showLabel #2247
Merged
+8
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the showLabel property from the inline edits system as part of technical debt cleanup. The showLabel feature was previously used to conditionally show labels for next edit suggestions when they were far from the cursor position, but this functionality is being removed to simplify the codebase.
Key Changes:
- Removed
showLabelproperty from thePushEdittype definition - Removed label generation logic that calculated "Jump to line N" labels for distant edits
- Simplified configuration options by removing
showLabelparameters from internal functions
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/inlineEdits/common/statelessNextEditProvider.ts | Removed showLabel property from PushEdit type definition |
| src/extension/xtab/node/xtabProvider.ts | Removed showLabel parameter from doGetNextEditWithSelection function and all call sites, simplified diff options logic |
| src/extension/inlineEdits/node/nextEditProvider.ts | Removed unused Range import, deleted complex label generation logic including INextEditDisplayLocation usage, and removed showLabel handling from cache operations |
| src/extension/inlineEdits/node/nextEditCache.ts | Removed showLabel property from CachedOrRebasedEdit type definition |
lszomoru
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.