cursor jump: fix modelNotSeenLineNumber incorrectly computing kept-range
#2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulugbekna
force-pushed
the
ulugbekna/known-dove
branch
from
e47f9d7 to
e43b4cf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where modelNotSeenLineNumber errors occurred due to incorrect calculation of the keptRange in clipped documents. The root cause was that areaAroundCodeToEdit was being treated as a single string (counted as 1 line) when building the taggedCurrentFileContent array, causing the keptRange.endExclusive to be computed incorrectly.
Key Changes:
- Refactored
areaAroundCodeToEditparameter fromstringtostring[]increateTaggedCurrentFileContentUsingPagedClippingto correctly represent it as an array of lines - Updated all intermediate variables and array operations to work with
string[]instead of joining/splitting strings - Converted back to
stringonly at the final return boundary wherePromptPiecesexpects a string
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/extension/xtab/common/promptCrafting.ts |
Changed areaAroundCodeToEdit parameter type from string to string[], updated array spreading to use ...areaAroundCodeToEdit, and converted back to string at return point |
src/extension/xtab/test/common/promptCrafting.spec.ts |
Updated test helper to split the string input into array before calling the function |
dmitrivMS
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.