CSV output now works with selected rows. #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk201-
previously approved these changes
Apr 7, 2025
mkrueger
force-pushed
the
dev/mkrueger/fix2639
branch
from
9ec74f8 to
ab776e7
Compare
sevoku
approved these changes
Apr 8, 2025
bk201-
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to enhance the functionality of saving query results, specifically by allowing the selection of specific rows to be saved as CSV or JSON files.
src/panels/QueryEditorTab.ts: Added aselectionparameter to thesaveCSVmethod and updated thesaveMetricsCSVmethod to handle the selection of specific rows. [1] [2]src/utils/convertors.ts: Modified thequeryResultToJSONfunction to remove theasynckeyword and handle the selection of specific rows.src/webviews/cosmosdb/QueryEditor/ResultPanel/ResultPanelToolbarOverflow.tsx: Updated theonSaveToClipboardAsJSON,onSaveAsCSV, andonSaveAsJSONfunctions to include theselectionparameter for saving specific rows. [1] [2] [3]src/webviews/cosmosdb/QueryEditor/state/QueryEditorContextProvider.tsx: Added aselectionparameter to thesaveCSVmethod to handle the selection of specific rows.Fixes #2639