-
Notifications
You must be signed in to change notification settings - Fork 77
feat: Localization dictionaries #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bk201-
commented
Apr 9, 2025
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- l10n/@microsoft/vscode-azext-azureauth/bundle.l10n.json: Language not supported
- l10n/@microsoft/vscode-azext-azureutils/bundle.l10n.json: Language not supported
- l10n/@microsoft/vscode-azext-utils/bundle.l10n.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
webpack.config.ext.js:14
- The supportedLanguages array is currently empty, which may cause the regex filters used later to fail to match any valid language files. Consider providing a default set of supported languages or add logic to handle an empty array scenario.
const supportedLanguages = [];
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted
|
@sevoku this PR doesn't add any of translated dictionary, but adds some checks and build scripts in order to avoid inconsistency in l10n.bundle.json |
# Conflicts: # webpack.config.ext.js # webpack.config.views.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- l10n/@microsoft/vscode-azext-azureauth/bundle.l10n.json: Language not supported
- l10n/@microsoft/vscode-azext-azureutils/bundle.l10n.json: Language not supported
- l10n/@microsoft/vscode-azext-utils/bundle.l10n.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (2)
l10n/scripts/check.l10n.mjs:11
- [nitpick] The function name 'checkLocalisationBundle' uses British English spelling, while other parts of the code and PR title use American English ('Localization'). Consider standardizing the spelling to ensure consistency across the codebase.
const checkLocalisationBundle = async () => {
l10n/scripts/build.l10n.mjs:11
- [nitpick] The function name 'buildLocalisationBundle' uses British English spelling, which is inconsistent with the 'Localization' terminology used elsewhere. Standardize the naming convention to prevent confusion.
const buildLocalisationBundle = async () => {
- Adds dictionaries from "@microsoft/vscode-azext-*" modules - Adds localization bundle checker to pipeline - All keys in bundle are sorted