Skip to content

Conversation

@bk201-
Copy link
Contributor

@bk201- bk201- commented Apr 9, 2025

  • Adds dictionaries from "@microsoft/vscode-azext-*" modules
  • Adds localization bundle checker to pipeline
  • All keys in bundle are sorted

bk201- added 2 commits April 8, 2025 15:51
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
@bk201- bk201- requested a review from a team as a code owner April 9, 2025 13:26
@bk201- bk201- requested a review from Copilot April 9, 2025 13:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (4)
  • l10n/@microsoft/vscode-azext-azureauth/bundle.l10n.json: Language not supported
  • l10n/@microsoft/vscode-azext-azureutils/bundle.l10n.json: Language not supported
  • l10n/@microsoft/vscode-azext-utils/bundle.l10n.json: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

webpack.config.ext.js:14

  • The supportedLanguages array is currently empty, which may cause the regex filters used later to fail to match any valid language files. Consider providing a default set of supported languages or add logic to handle an empty array scenario.
const supportedLanguages = [];

bk201- added 5 commits April 9, 2025 16:19
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
@bk201-
Copy link
Contributor Author

bk201- commented Apr 11, 2025

@sevoku this PR doesn't add any of translated dictionary, but adds some checks and build scripts in order to avoid inconsistency in l10n.bundle.json

sevoku
sevoku previously approved these changes Apr 14, 2025
# Conflicts:
#	webpack.config.ext.js
#	webpack.config.views.js
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 11 changed files in this pull request and generated 2 comments.

Files not reviewed (4)
  • l10n/@microsoft/vscode-azext-azureauth/bundle.l10n.json: Language not supported
  • l10n/@microsoft/vscode-azext-azureutils/bundle.l10n.json: Language not supported
  • l10n/@microsoft/vscode-azext-utils/bundle.l10n.json: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

l10n/scripts/check.l10n.mjs:11

  • [nitpick] The function name 'checkLocalisationBundle' uses British English spelling, while other parts of the code and PR title use American English ('Localization'). Consider standardizing the spelling to ensure consistency across the codebase.
const checkLocalisationBundle = async () => {

l10n/scripts/build.l10n.mjs:11

  • [nitpick] The function name 'buildLocalisationBundle' uses British English spelling, which is inconsistent with the 'Localization' terminology used elsewhere. Standardize the naming convention to prevent confusion.
const buildLocalisationBundle = async () => {

- Adds dictionaries from "@microsoft/vscode-azext-*" modules
- Adds localization bundle checker to pipeline
- All keys in bundle are sorted
@bk201- bk201- merged commit 1b614aa into main Apr 29, 2025
2 checks passed
@bk201- bk201- deleted the dev/bk201-/add-dictionaries-from-azure-utils branch April 29, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants