chore: Removes unsafe and outdated dependencies #2673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates several dependencies and configuration files to remove outdated and unsafe code while modernizing ESLint, Prettier, and related tooling. Key changes include updating language client imports and disposal handling, replacing deprecated file system utilities, and migrating to new dependency versions such as es-toolkit for merging and updated deletion APIs.
Reviewed Changes
Copilot reviewed 71 out of 76 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/documentdb/scrapbook/languageClient.ts | Updates language client import and disposal method to use proper client stoppage. |
| src/documentdb/ShellScriptRunner.ts | Migrates file system operations from fs-extra to node:fs/promises and replaces path checking utility. |
| src/documentdb/ClustersClient.ts | Removes surplus eslint disable comments and cleans up replaceOne API usage. |
| src/cosmosdb/getCosmosClient.ts | Replaces lodash.merge with es-toolkit’s merge and updates internal client options. |
| src/commands/deleteDatabaseAccount/deleteMongoClustersAccount.ts | Changes deletion API call from beginDeleteAndWait to pollUntilDone. |
| Other files | Various dependency updates and configuration file migrations (ESLint, Prettier, etc.). |
Files not reviewed (5)
- .eslintignore: Language not supported
- .prettierrc: Language not supported
- .swcrc: Language not supported
- .vscodeignore: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/cosmosdb/getCosmosClient.ts:11
- Ensure that the es-toolkit merge function provides the same deep merge behavior as lodash.merge, as differences in merge strategies might lead to unexpected configuration issues.
import { merge } from 'es-toolkit';
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
# Conflicts: # package-lock.json # package.json
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
ghiscoding
reviewed
May 1, 2025
# Conflicts: # package.json # src/tree/workspace-api/SharedWorkspaceResourceProvider.ts # src/tree/workspace-view/cosmosdb/LocalEmulators/LocalCoreEmulatorsItem.ts
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
- Updates ESLint - ESLint and Prettier use modern configuration file - Unused eslint comments were removed - tsconfig uses ES2023 since Node.js 20.9 fully supports it - Updates language server and client - Updates slickgrid and styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.