IntelliSense-based Go to Declaration failed in this case

[lh123]

Originally posted by @lh123 in #2743 (comment)

In 0.20.1. I thinks this problem still exits.

1. Step to reproduce:

1. Add #include <list>.
2. A function named insert only defined.

2. Code:

#include <list>//Need include list to reproduce

void insert(int a) {//Need function name is 'insert'

}

int main() {
    insert(0);//Go to Declaration At here.
}

#include <list>

void otherName(int a) {

}

int main() {
    otherName(0); //Go to Declaration is correct.
}

3. Screenshort:

[lh123]

@sean-mcmanus
Thank you for your reply.

1. Yes, I am use MinGW-W64 8.2.0 in MSYS2.
2. Before I do Go to Declaration, I am sure that the red flame has disappeared.
3. Go to Definition works fine.

[sean-mcmanus]

The usage of "__catch()" in stl_list.h caused our parser to parse the file incorrectly (i.e. parsing the insert call as a declaration). Adding "#define __catch()" to the cpp.hint file in our extension install location should "workaround" the issue after also doing a Reset IntelliSense Database command. We should have a fix in our Insider release later this week.

[sean-mcmanus]

Should be fixed with 0.21.0-insiders (auto installed if "C_Cpp.updateChannel": "Insiders" is set, or manually installed from the offline vsix). Let us know if you find any problems with it.