Fix selection and formatting for CDD (and extra newlines with clang-format) #10177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
previously approved these changes
Nov 23, 2022
Member
bobbrow
left a comment
bobbrow
left a comment
There was a problem hiding this comment.
I'm fine with this. Only cosmetic feedback.
Contributor
Author
|
I'm still investigating a potential bug... |
Contributor
Author
bobbrow
previously approved these changes
Nov 23, 2022
Contributor
Author
|
@bobbrow I pushed a minor fix of an issue I hit when using vcFormat. |
Supsource
approved these changes
Nov 26, 2022
bobbrow
approved these changes
Nov 28, 2022
Colengms
approved these changes
Nov 28, 2022
michelleangela
approved these changes
Nov 28, 2022
sean-mcmanus
added a commit
that referenced
this pull request
Nov 28, 2022
…ormat) (#10177) * Fix selection and formatting for CDD. * Fix multiple edit at the same spot case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10161, #10160.
Also #10164 for clang-format due to a by-product of its extra newline removal).