-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update issue templates #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update issue templates #2087
Conversation
|
I'm confused as to what the difference is between [tag]-issue.md and [tag].md is. They look like duplicates of each other. Is there a reason for this that I just don't understand? Is one supposed to be a feature request and the other a bug? |
|
|
||
| **Additional context** | ||
| *Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Starting with 0.17.3, Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "http://msdl.microsoft.com/download/symbols".* | ||
| Add any other context about the problem here including log messages in your Output window ("C_Cpp.loggingLevel": "Information" in settings.json). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to list "Debug" instead of "Information" for the logging level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled it out of the current template. Is it supposed to be "debug" ?
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
| - Browser [e.g. chrome, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| **Smartphone (please complete the following information):** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smartphone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is a lot of boilerplate left in these templates. Can you remove the stuff that doesn't apply?
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
|
|
||
| **Desktop (please complete the following information):** | ||
| - OS: [e.g. iOS] | ||
| - Browser [e.g. chrome, safari] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think Browser matters
|
@bobbrow I'll see what i can do. I used their tool within the repo and it created the templates. |
|
Are we going to add a feature request template too? |
|
@bobbrow Most of our feature requests come from bug reports, which will filter to which section that feature will be for. I would suggest starting with an Issue template and marking it with a label as a feature request. |
bobbrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general template has some stuff that should be removed.
| - Browser [e.g. chrome, safari] | ||
| - Version [e.g. 22] | ||
|
|
||
| **Smartphone (please complete the following information):** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove smartphone section
| **Screenshots** | ||
| If applicable, add screenshots to help explain your problem. | ||
|
|
||
| **Desktop (please complete the following information):** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove desktop section (duplicate info as the Describe section)
|
With the new templates, I would remove ISSUE_TEMPLATE.md |
bobbrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
No description provided.