Skip to content

minor tweaks to config provider experience #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2018
Merged

minor tweaks to config provider experience #2302

merged 2 commits into from
Jul 27, 2018

Conversation

@bobbrow
Copy link
Member

@bobbrow bobbrow commented Jul 20, 2018

  • In the Change Configuration Provider command, show which one is currently active
  • If no c_cpp_properties.json is present, delete the workspace setting when the config provider is cleared
  • When generating c_cpp_properties.json for a folder, delete the workspace setting (it is assumed this was added via the command or UI prompts)

@bobbrow bobbrow merged commit 1009b76 into master Jul 27, 2018
@bobbrow bobbrow deleted the bobbrow/apiTweaks branch July 27, 2018 16:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobbrow @sean-mcmanus