Skip to content

Disable the IntelliSense cache on Mac. #3293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2019
Merged

Disable the IntelliSense cache on Mac. #3293

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b290251
Disable the IntelliSense cache on Mac.
sean-mcmanus Mar 14, 2019
8a7d80b
Merge branch 'master' into seanmcm/disableMacPCH
sean-mcmanus Mar 14, 2019
5417b7c
Update comment.
sean-mcmanus Mar 14, 2019
12d4e6c
Merge branch 'seanmcm/disableMacPCH' of https://github.com/Microsoft/…
sean-mcmanus Mar 14, 2019
1751fee
Trivial wording change.
sean-mcmanus Mar 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,13 @@ class DefaultClient implements Client {

let intelliSenseCacheDisabled: boolean = false;
if (os.platform() === "darwin") {
const releaseParts: string[] = os.release().split(".");
if (releaseParts.length >= 1) {
// AutoPCH doesn't work for older Mac OS's.
intelliSenseCacheDisabled = parseInt(releaseParts[0]) < 17;
}
intelliSenseCacheDisabled = true;
// TODO: Re-enable this after the performance is improved on Mac.
//const releaseParts: string[] = os.release().split(".");
//if (releaseParts.length >= 1) {
// // AutoPCH doesn't work for older Mac OS's.
// intelliSenseCacheDisabled = parseInt(releaseParts[0]) < 17;
//}
}

let clientOptions: LanguageClientOptions = {
Expand Down