Taraj/box sample #3314
Merged
Taraj/box sample #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tara-raj
requested review from
bobbrow,
michelleangela,
mluparu and
sean-mcmanus
mluparu
reviewed
Mar 19, 2019
mluparu
reviewed
Mar 19, 2019
Member
|
there are some binary files that are not worth adding to the checkin. might as well remove them |
mluparu
reviewed
Mar 19, 2019
Contributor
michelleangela
left a comment
michelleangela
left a comment
There was a problem hiding this comment.
I would emit the ipch cache files as these would only be valid on the machine they were created on
Member
|
@tara-raj and I talked about this offline. She'll be making some changes and then update the PR. |
Author
|
@bobbrow made changes as requested. Kept the folder name as "BoxConsoleSample" so let me know if you'd like me to change that |
Member
|
Please add a .gitignore that excludes the ipch folder. |
bobbrow
reviewed
Mar 26, 2019
bobbrow
approved these changes
Mar 26, 2019
Member
bobbrow
left a comment
bobbrow
left a comment
There was a problem hiding this comment.
I made some changes. Please review them.
Contributor
|
@tara-raj Are you able to check this in (squash and merge) or did you want one of us to? |
Author
|
Was able to merge once the changes were approved. Done! Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding code for the box sample used in our recent blog posts.
This sample showcases build & debug active file. It is intended for users to see a complete working project and view the tasks.json and launch.json files that are generated.