Bobbrow/webpack #3411
Merged
Bobbrow/webpack #3411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Apr 5, 2019
Contributor
Author
|
Looks like this breaks the Azure Pipeline build...even though building works locally. Error: Cannot find module './out/tools/GenerateOptionsSchema' |
WardenGnaw
reviewed
Apr 5, 2019
Member
WardenGnaw
left a comment
WardenGnaw
left a comment
There was a problem hiding this comment.
I wouldn't webpack src/tools, since it is not used for the released VsCode extension.
I would add another agent build for testing webpacked builds and keep our normal just tsc builds since we do not want webpacking for regular dev workflow.
Add Extension/dist/* to .gitignore
WardenGnaw
force-pushed
the
bobbrow/webpack
branch
from
7208ae9 to
66dd769
Compare
Member
|
When the Config UI goes in, we'll need to update this to make sure all the assets are in the right place. |
Webpack will be doing all the compilation. However we need to tsc specific support files in order for our checks and tests to work. Added webpack watch Fix tslint Debugger intergration tests are broken and will not work with webpack. Fix .vscodeignore list to ignore out since now everything should be published to dist.
support.ts will not be webpacked since it is needed for settings.html. tscCompileList.txt will be used for typescript files that need to be individually consumed as a .js file instead of being webpacked. Updated .vscode ignore to remove unnecessary files.
WardenGnaw
force-pushed
the
bobbrow/webpack
branch
from
66dd769 to
a7f6d9c
Compare
bobbrow
approved these changes
Apr 24, 2019
|
Linking #3213 as it is fixed with this merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging doesn't work. Something wrong with the source mapping I guess.