Skip to content

In provideCustomConfiguration, move the check for a configuration provider to before the call to QTUS. #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

In provideCustomConfiguration, move the check for a configuration provider to before the call to QTUS. #3437

merged 1 commit into from
Apr 11, 2019

Conversation

@Colengms
Copy link
Contributor

@Colengms Colengms commented Apr 9, 2019

Moves the check for a configuration provider to before the call to QTUS, in provideCustomConfiguration.

This is an optimization, as the check for configuration provider may provide a quick exit.

@Colengms Colengms merged commit c978eb0 into master Apr 11, 2019
@Colengms Colengms deleted the dev/coleng/ProvideCustomConfigurationOptimization branch April 11, 2019 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Colengms @sean-mcmanus