Adding support for .env files for cppvsdbg #3500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Addresses #3490 |
Contributor
|
Is this targeting 0.23.0-insiders? |
Member
Author
|
@michelleangela there’s no big rush for this PR |
chuckries
approved these changes
Apr 23, 2019
bobbrow
reviewed
Apr 24, 2019
Contributor
|
@WardenGnaw Can you check this in by our 0.23.0-insiders2 on Friday? We want the next Insiders to be as close to the final release as possible. |
This PR allows users to have a .env file that listed as KEY=VALUE or KEY="VALUE WITH SPACE" to be used as environment variables when launching a process. Anything that begins with '#' is treated as a comment. Blank lines are ignored. This .env file will be used if envFile passed in with the launch.json. It will also work with the existing environment variable, however anything listed in the .env file will overwrite anything from the environment field in the launch.json.
WardenGnaw
force-pushed
the
dev/waan/vsdbgEnvFile
branch
from
2487bee to
826ba4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to have a .env file that listed as
KEY=VALUE or KEY="VALUE WITH SPACE" to be used as environment variables
when launching a process. Anything that begins with '#' is treated as a
comment. Blank lines are ignored.
This .env file will be used if envFile passed in with the launch.json.
It will also work with the existing environment variable, however
anything listed in the .env file will overwrite anything from the
environment field in the launch.json.
@gregg-miskelly