Fix issue with didClose received before didOpen #3844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Jul 4, 2019
Colengms
changed the title
Colengms
added a commit
that referenced
this pull request
Jul 18, 2019
Colengms
added a commit
that referenced
this pull request
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes provideCustomConfiguration() a blocking task, so any calls to notifyWhenReady/requestWhenReady will wait for it to complete.
Removed use of notifyWhenReady/requestWhenReady from within provideCustomConfiguration, to avoid deadlock.
Fixed issue with queueBlockingTask() not returning a promise.
Fixed issue with BlockingTask not setting Done to true when done.
Added callTaskWithTimeout(), which is the same as queueTaskWithTimeout() but does not defer using queueTask(). This is used to add a timeout to calls to custom configuration provider (which should no longer queue against the blocking task, since it is already a blocking task).