don't overwrite options and args #6374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elahehrashedi
force-pushed
the
ella/6366
branch
from
0dde543 to
dedfab6
Compare
sean-mcmanus
approved these changes
Oct 22, 2020
Contributor
|
This fixes the args being used, but I have to change the label/name still. Are you able to repro the label/name issue? Should I create a new issue for that? Also I'm seeing debugging not working with mingw on Windows, but that seems to repro without this change. |
Contributor
|
If you want to get this into 1.1.0-insiders3 can you update the changelog.md? |
Contributor
Author
|
@sean-mcmanus I changes the changelog. the label name issue is in another reported issue that I have to address. |
added 2 commits
October 22, 2020 16:10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't overwrite options and args when building from a custom defined task
bugfix: #6366