fix terminal issues (windows/linux/linux-on-wsl verified) #6384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elahehrashedi
changed the title
bobbrow
reviewed
Oct 24, 2020
| } | ||
|
|
||
| const splitWriteEmitter = (lines: string | Buffer) => { | ||
| for (const line of lines.toString().replace("\r\n", "\n").split("\n")) { |
Member
There was a problem hiding this comment.
I think you can split on a regex so that you don't have to substitute before splitting the lines. Something like this (not tested): lines.toString().split(/\r?\n/g)
sean-mcmanus
approved these changes
Oct 26, 2020
elahehrashedi
changed the title
elahehrashedi
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated on 10/27:
wsl:
windows (g++):
windows (cl.exe):
