Add localization to strings in LanguageServer\cppBuildTaskProvider.ts#6544
Merged
Conversation
Colengms
requested changes
Nov 18, 2020
Colengms
approved these changes
Nov 19, 2020
sean-mcmanus
requested changes
Nov 19, 2020
sean-mcmanus
requested changes
Nov 20, 2020
| telemetry.logLanguageServerEvent("cppBuildTaskError"); | ||
| const dot: string = (stdout || _stderr) ? ":" : "."; | ||
| this.writeEmitter.fire(`Build finished with error${dot}${this.endOfLine}`); | ||
| this.writeEmitter.fire(localize("build_finished_with_error", "Build finished with error") + dot + this.endOfLine); |
Contributor
There was a problem hiding this comment.
"Build finished with error." is not grammatically correct...if that case is possible it should be "Build finished with an error" or "Build finished with errors", so correct translation of "Build finished with error" might not have enough info to translate correctly...something like "Build finished with errors:" might work (not sure if "error" versus "errors" matters if there's one error).
Contributor
Author
There was a problem hiding this comment.
the dot variable is either : or . that is why it is not included in the sentence.
I replaced it with a more common sentence Build finished with error(s)
elahehrashedi
force-pushed
the
ella/localization
branch
from
04b29dc to
d8bfe33
Compare
sean-mcmanus
approved these changes
Nov 25, 2020
sean-mcmanus
pushed a commit
that referenced
this pull request
Dec 2, 2020
…#6544) * localizing for task provider * localize single_file_mode_not_available * remove end of line from localalized string * modify error(s) * remove space from localized string * remove space from localized string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix : #6436