check for failed tasks#9205
Conversation
There was a problem hiding this comment.
Is the real problem that resolve(-1) doesn't exit the function and we immediately send resolve(0) right after this? What happens if you just add a return; after line 444? Maybe the reason this change works is because it now ignores the -1 and 0 returned in the failed build case.
(It's possible you might also need to do something to deal with multiple resolves being called if both the error block and the close block can execute.)
There was a problem hiding this comment.
In new changes, I kept the result of the promise and checked for when it is -1.
bobbrow
left a comment
bobbrow
left a comment
There was a problem hiding this comment.
Requesting changes since this PR was approved already, but I'm not confident it's the right way to go.
michelleangela
dismissed
their stale review
Better way to address issue was suggested.
elahehrashedi
force-pushed
the
elrashed/failedtask
branch
from
49d3347 to
f3ee553
Compare
| this.closeEmitter.fire(result); | ||
| } catch { | ||
| this.closeEmitter.fire(-1); | ||
| return -1; |
3 participants
bug fix: #9060
bug fix: #8828