Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y_Visual Studio Code Services_Docs Python_Tutorial_DeveloperTool: Incorrect role given for "Edit" control as "link" and "Button" #5554

Closed
prabhudevu opened this issue Aug 8, 2022 · 1 comment
Assignees
Labels
accessibility docs-experience feedback on code.visualstudio.com experience

Comments

@prabhudevu
Copy link

prabhudevu commented Aug 8, 2022

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags:#A11yMAS;#A11yTCS;#BM_Visual Studio Code Services_Aug2022;#Visual Studio Code Services;#Win11;#FTP;#DesktopWeb;#A11ySev2;#Chrome;#WCAG4.1.2;#DeveloperTool;#Closed;

Environment Details:

Application Name: Visual Studio Code Services
URL: https://code.visualstudio.com/
Windows Version: Win11
Chrome Version: Version 103.0.5060.134 (Official Build) (64-bit)
Screen reader: NVDA (version 2022.1), JAWS (version 2022.2112.24 ILM)

Repro Steps:

  1. Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility tester after verification of the fix
  2. Launch the application Url : https://code.visualstudio.com/
  3. Tab Navigate to "Docs" link.
  4. Tab Navigate to "Tutorial" link under "Python" in left Navigation and hit enter
  5. Turn on the screen reader
  6. Tab Navigate to "Edit" beside "Getting Started with Python in VS Code" heading
  7. Observe that Screen reader is announcing both "link" and "button" when focus is on "Edit" .Role of "Edit" is given as both link and button

Actual:

Role of "Edit" is given as both link and button, Screen reader is announcing both "link" and "button" when focus is on "Edit" control on using tab key
Note:

  1. Issue is observed throughout the application
  2. Issue is Observed with JAWS screen reader as well

Expected:

Role of "Edit" should be only given as "link" button role should be removed. On activating "Edit" control the URL is getting changed so the role should only be "link"

User Impact:

Screen reader users will find it difficult to know the role if Screen reader is announcing both "link" and "button" when focus is on "Edit" control

Attachment

5554_A11y_Visual Studio Code Services_Docs Python_Tutorial_DeveloperTool
5554_A11y_Visual Studio Code Services_Docs Python_Tutorial_DeveloperTool

@gregvanl gregvanl added accessibility docs-experience feedback on code.visualstudio.com experience labels Aug 8, 2022
@prabhudevu prabhudevu changed the title A11y_Visual Studio Code Services_Docs Python_Tutorial_DeveloperTool: Incorrect role given for "Edit" link, Screen reader is announcing both "link" and "button" when focus is on "Edit" A11y_Visual Studio Code Services_Docs Python_Tutorial_DeveloperTool: Incorrect role given for "Edit" control as "link" and "Button" Aug 11, 2022
@rzhao271 rzhao271 self-assigned this Oct 10, 2022
@gregvanl gregvanl assigned prabhudevu and unassigned rzhao271 Oct 12, 2022
@prabhudevu
Copy link
Author

5554_closed

I have verified the issue in the Env: https://code.visualstudio.com/docs/python/python-tutorial
Issue is fixed, hence closing the bug.

GithubTags: #Closed;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility docs-experience feedback on code.visualstudio.com experience
Projects
None yet
Development

No branches or pull requests

3 participants