Conversation
ntrogh
requested review from
Copilot and
isidorn
and removed request for
Copilot
|
@ntrogh thank you for pushing on this one. Is this PR ready for my review/feedback? |
|
@isidorn yes, feel free to review. Thanks |
docs/copilot/agents/agent-tools.md
Outdated
|
|
||
| > [!NOTE] | ||
| > Terminal sandboxing is currently in preview and is only supported on macOS and Linux. On Windows, the sandbox settings have no effect. | ||
| > Terminal sandboxing is currently in preview and is only supported on macOS and Linux. On Windows, only WSL2 environments are supported. |
There was a problem hiding this comment.
This puts Windows as not officially supported. But WSL might be the actual path forward. I would frame it slightly differently for windows to say that it uses WSL
There was a problem hiding this comment.
I would not say only WSL2 environemnts are supported, but that we use WSL2 as an underlying implementation. At the end of the day users might not care
| * Network access is blocked for all domains by default | ||
| * Commands run without the standard confirmation dialog | ||
| * Commands have read access to the entire file system | ||
| * Commands have write access only to the current working directory and its subdirectories |
There was a problem hiding this comment.
@dileepyavan is this correct? What about the TMP directory - how are we treating it now?
|
Great start. I left comments. @dileepyavan would be great if you can also give this a review some time this week |
2 participants
Fixes #9588