Fix Azure Resource ID sanitization documentation and tests #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple tests and comments incorrectly documented Azure Resource ID sanitization as using dash (
-) when the implementation uses underscore (_).Changes
Tests corrected:
BaseClusterModel.test.ts: Two test cases now use.replace(/\//g, '_')instead of.replace(/\//g, '-')DiscoveryBranchDataProvider.test.ts: Fixed test to expect error throw (matches implementation) instead of warningComments corrected:
VCoreBranchDataProvider.ts: Updated inline comment to "replace '/' with '_'"RUBranchDataProvider.ts: Updated inline comment to "replace '/' with '_'"All changes align with the actual
sanitizeAzureResourceIdForTreeId()implementation:These issues were previously marked as resolved but the incorrect documentation remained in the codebase.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.