fix: copy paste log on write errors not always shown#484
Merged
Conversation
…n DocumentDbStreamingWriter
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request improves error visibility during paste operations by enhancing logging for duplicate key violations and ensuring users can immediately see error details in the output channel.
Changes:
- Enhanced error logging in skip and abort strategies to include MongoDB error details (e.g., which unique index caused the violation)
- Changed logging from debug/trace to warn/error levels for better visibility
- Automatically reveals the output channel when a task fails
- Updated localization strings to be more descriptive and context-aware
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/services/taskService/data-api/writers/DocumentDbStreamingWriter.ts |
Enhanced error logging for skip and abort strategies with detailed MongoDB error messages; changed log levels from debug/trace to warn/error for better visibility |
src/services/taskService/taskService.ts |
Changed task failure logging to use error() method and automatically reveal output channel |
l10n/bundle.l10n.json |
Updated localization strings with more descriptive messages for skip and abort strategies; removed outdated strings |
sajeetharan
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Summary
This pull request addresses issues with error visibility during paste operations, particularly for duplicate key violations on unique indexes. The changes ensure that error details are logged appropriately, improving the debugging experience for users.
Changes Made
1.
DocumentDbStreamingWriter.ts_idconflicts and unique index violations.2.
taskService.tserror()method.Verification
npm run build.npm run l10n.Impact
These changes improve the visibility of errors during paste operations, making it easier for users to debug issues related to duplicate key violations. The updates also enhance the overall user experience by ensuring critical error details are not missed.
Related Issues