fix: standardize telemetry property conventions#599
Merged
tnaum-ms merged 1 commit intorel/release_0.8.0from Apr 22, 2026
Merged
fix: standardize telemetry property conventions#599tnaum-ms merged 1 commit intorel/release_0.8.0from
tnaum-ms merged 1 commit intorel/release_0.8.0from
Conversation
- Remove redundant result override in manageCredentials catch block (wrapper auto-sets result='Failed' on throw) - Convert boolean .toString() to explicit ternary pattern across survey.ts, CopyPasteCollectionTask.ts, clusterHelpers, extension.ts, FilterTenantSubStep.ts - Move numeric values from string properties to measurements: triggerActionScore, fullScore, pageNumber, tenantCountFromSubscriptions, receivedAuthMethodsCount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes telemetry property patterns across the codebase based on the audit from the new
telemetry-instrumentationskill.Changes
Redundant result override (Issue 3)
manageCredentials.tsthat manually setresult = 'Failed'before re-throwing — thecallWithTelemetryAndErrorHandlingwrapper handles this automatically.Boolean
.toString()→ ternary (Issue 4)booleanValue.toString()patterns to explicitvalue ? 'true' : 'false'ternaries across:survey.ts(6 instances:isSurveyDisabledGlobally,wasPromptedInSession,scoreTargetReached,isCandidate,acceptedForABTest)CopyPasteCollectionTask.ts(isCrossConnection,targetWasCreated)ruClusterHelpers.ts/clusterHelpers.ts(isCustomCloud)FilterTenantSubStep.ts(allTenantsSelectedForFiltering,noTenantsSelectedForFiltering)extension.ts(enableAIQueryGeneration)Numbers as properties → measurements (Issue 5)
properties(string) tomeasurements(number) so they can be aggregated (P50, avg, sum) in analytics:survey.ts:triggerActionScore,fullScorecollectionViewRouter.ts:pageNumberInitializeFilteringStep.ts:tenantCountFromSubscriptionsclusterHelpers.ts:receivedAuthMethodsCountNot changed
domainInfo_*/serverInfo_*snake_case naming is intentional (prefix-as-namespace for metadata spread) and matched by existing dashboard queries.connectioncorrelationid(Issue 2): Already camelCase on this branch.Validation
npm run prettier-fix✅npm run lint✅ (596 pre-existing errors inpackages/, none introduced)