fix: display shard key in collection tooltip#670
Open
lte-z wants to merge 2 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Exposes sharding metadata in the DocumentDB tree UI by preserving the shard key from listCollections() and rendering it in the collection tooltip.
Changes:
- Extend
CollectionItemModelwith an optionalshardKeyproperty populated fromlistCollections()results. - Update
CollectionItemtooltip to conditionally display shard key details when present. - Add localization string for “Shard Key”.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tree/documentdb/CollectionItem.ts | Adds shard key section to the collection tooltip. |
| src/documentdb/ClustersClient.ts | Extracts and stores shard key from listCollections() into the collection model. |
| l10n/bundle.l10n.json | Adds localized string entry for “Shard Key”. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@lte-z Thank you for your contribution and for addressing Copilot review. I'll review your PR tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #661
Changes
This PR exposes shard key information for sharded collections in the tree view tooltip.
CollectionItemModelto include optionalshardKeyfieldlistCollections()response inClustersClientCollectionItemtooltip when presentBehavior
Notes
1) and hashed shard key formats