feat: Improve auto-completion for dependencies#1090
Merged
Conversation
CsCherrYY
force-pushed
the
cs-local-repository
branch
from
c635778 to
fc6dec3
Compare
CsCherrYY
changed the title
CsCherrYY
force-pushed
the
cs-local-repository
branch
from
c02f457 to
6ce0da2
Compare
CsCherrYY
force-pushed
the
cs-local-repository
branch
from
6ce0da2 to
92b7891
Compare
Eskibear
reviewed
Dec 7, 2021
| return allFiles; | ||
| } | ||
|
|
||
| public static List<File> listAllFiles(File folder, String ext) { |
Member
There was a problem hiding this comment.
consider whether it's ok to use Files.walk() directly?
Eskibear
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #990, fix #981
This PR introduces the following changes:
DependencyCompletionHandleris renamed toMavenCentralCompletionHandlerto distinguish the newMavenLocalCompletionHandler