chore: bump @electron/get to v5, migrate to got v15, fix audit vulnerabilities#44
Merged
Merged
Conversation
…nerabilities Agent-Logs-Url: https://github.com/microsoft/vscode-gulp-electron/sessions/671801c3-c5dd-4078-aca7-11bbb0a65a77 Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rzhao271
May 14, 2026 16:12
View session
Contributor
|
@copilot Migrate to got v15 |
Agent-Logs-Url: https://github.com/microsoft/vscode-gulp-electron/sessions/94aad30c-aaff-4279-ba86-974201a271d2 Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Contributor
Author
Done in b7a8d01. Also updated Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
chore: bump @electron/get to v5, add got as direct dep, fix audit vulnerabilities
chore: bump @electron/get to v5, migrate to got v15, fix audit vulnerabilities
May 14, 2026
rzhao271
approved these changes
May 14, 2026
Contributor
|
@copilot Also confirm that workflows and pipelines are using node 22 |
Contributor
Author
Already confirmed — |
amunger
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@electron/getfrom^4.0.1to^5.0.0gotas a direct dependency (^15.0.5) — @electron/get v5 dropped it from its own deps, butsrc/download.jsuses it directlysrc/download.jsto useconst got = require("got").default— got v15 removed the undocumented namedgotexport, leaving only the default exportoverridesfor transitive deps in mocha:diff→^9.0.0(fixes CVE in 6.0.0–8.0.2 range)serialize-javascript→^7.0.5(fixes two CVEs in ≤7.0.4)azure-pipelines.ymlalready usesnodeVersions: [22.x, 24.x]andengines.nodeis already>=22— no changes needed thereTest Results
13 tests pass, 4 are pending. One test (
should download from a custom repo) fails only in the sandboxed CI environment due to a DNS proxy blocking network requests — this is not a code regression.